Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage: ignore embedded Rails apps #85

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

jeremy
Copy link
Contributor

@jeremy jeremy commented Mar 5, 2018

Addresses misleading coverage churn in #83 and #84.

Ignore embedded Rails apps and the specs themselves.
@jeremy jeremy force-pushed the omit-railsapps-coverage branch from 183c7f6 to a60d82c Compare March 5, 2018 06:32
@codecov-io
Copy link

codecov-io commented Mar 5, 2018

Codecov Report

Merging #85 into master will increase coverage by 1.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   96.82%   98.38%   +1.56%     
==========================================
  Files          21       16       -5     
  Lines         598      496     -102     
==========================================
- Hits          579      488      -91     
+ Misses         19        8      -11
Impacted Files Coverage Δ
lib/roadie-rails.rb
spec/support/have_no_styling_matcher.rb
spec/support/have_styling_matcher.rb
spec/support/rails_app.rb
spec/support/have_selector_matcher.rb

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70784cf...a60d82c. Read the comment docs.

@Mange
Copy link
Owner

Mange commented Mar 5, 2018

Thanks!

@Mange Mange merged commit c651b5c into Mange:master Mar 5, 2018
@jeremy jeremy deleted the omit-railsapps-coverage branch March 5, 2018 18:27
@tricknotes tricknotes mentioned this pull request Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants